Allow passing of install task variables to downstream tasks of a dag #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
- Coverage 93.32% 93.24% -0.08%
==========================================
Files 24 24
Lines 1003 1007 +4
==========================================
+ Hits 936 939 +3
- Misses 67 68 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix makes it possible to pass variables generated in the install task namely the cluster name and UUID of the install task for rosa and rogcp dags. The passed variables can be accessed by any of the following tasks(benchmarks,cleanup etc) in the dag.
A limitation of the bash operator is that only a single string can be passed from a task(script), so a concatenation of the above 2 vars, separated by '@' delimiter is passed, the receiving tasks have to separate the 2 from the pulled string.
Dag run eg: dag link
The passed string is accessible to the benchmark scripts and the cleanup script.
Fixes
https://issues.redhat.com/browse/PERFSCALE-1520